[PowerShell] discard readonly properties in Initialize cmdlets#6754
Merged
wing328 merged 27 commits intoOpenAPITools:masterfrom Jun 25, 2020
Merged
[PowerShell] discard readonly properties in Initialize cmdlets#6754wing328 merged 27 commits intoOpenAPITools:masterfrom
wing328 merged 27 commits intoOpenAPITools:masterfrom
Conversation
…uration.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
…uration.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
…uration.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
…uration.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
…uration.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
…ignature_auth.mustache Co-authored-by: Sebastien Rosset <serosset@cisco.com>
Update the fork repo
Ghufz
changed the title
Member
|
Pushed a commit to update the doc. Let's see if that fixes the CI failure. |
wing328
reviewed
Jun 25, 2020
|
|
||
| $PSO = [PSCustomObject]@{ | ||
|
|
||
| $PSO = [PSCustomObject]@{ |
Member
There was a problem hiding this comment.
FYI. I'll file a separate PR to replace tabs with spaces
wing328
reviewed
Jun 25, 2020
|
|
||
| // Mark the last readonly false property | ||
| if(this.discardReadOnly && lastWritableProperty != null) { | ||
| lastWritableProperty.vendorExtensions.put("x-lastWritable", true); |
Member
There was a problem hiding this comment.
I'll rename the extension to x-ps-last-writable instead to make it conform to the naming convention
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Discard the readOnly properties for Initialize cmdlets, This can be useful for New and Set cmdlets to deal with only non readonly properties.
To achieve this user needs to add the following in config file.
discardReadOnly: truePR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.master@wing328