Skip to content

[PS] better code format, vendor extension naming#6778

Merged
wing328 merged 3 commits intomasterfrom
ps-enhance1
Jun 25, 2020
Merged

[PS] better code format, vendor extension naming#6778
wing328 merged 3 commits intomasterfrom
ps-enhance1

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Jun 25, 2020

  • better code format
  • vendor extension naming

cc @Ghufz

PR checklist

  • Read the contribution guidelines.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/config/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 wing328 merged commit 36930fe into master Jun 25, 2020
@wing328 wing328 deleted the ps-enhance1 branch June 25, 2020 10:09
@ybelenko
Copy link
Contributor

ybelenko commented Jun 25, 2020

Unfortunately PHP 7.2.15 isn't enough for latest Symfony and Laravel. Both requires ^7.2.5
https://packagist.org/packages/symfony/framework-bundle
https://packagist.org/packages/laravel/framework

UPD: Lumen requires ^7.2.5 too.

@wing328
Copy link
Member Author

wing328 commented Jun 26, 2020

Then 7.2.15 should meet the requirement (15 > 5), right?

@ybelenko
Copy link
Contributor

You're right. I'm confused. Maybe it was different dist in my previous PRs, not dist: xenial. Xenial environment doesn't contain preinstalled PHP versions higher than 7.2, but it's not a big deal until 30 Nov 2020.

@wing328
Copy link
Member Author

wing328 commented Jun 26, 2020

👌 let's deal with it later after the image installs with a newer version of php

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants