Fix issue bodyclose golang#7041
Closed
gmtstephane wants to merge 4 commits intoOpenAPITools:masterfrom
gmtstephane:fix_issue_bodyclose_golang
Closed
Fix issue bodyclose golang#7041gmtstephane wants to merge 4 commits intoOpenAPITools:masterfrom gmtstephane:fix_issue_bodyclose_golang
gmtstephane wants to merge 4 commits intoOpenAPITools:masterfrom
gmtstephane:fix_issue_bodyclose_golang
Conversation
Member
|
@gmtstephane thanks for the PR. I think #6948 is related. Can you please review when you've time? |
Contributor
Author
|
Hi, https://golang.org/pkg/net/http/ . This issue is a bit annoying at the moment since the generated client is not working at all and we have to patch all files each time we generate. Thanks for your comment |
5 tasks
Contributor
Author
|
Contributor
|
@gmtstephane: It is quite possible I am missing something, but how does this allow a user to get the body from the returned http.Response given the body has already been read? |
Member
|
Closed via #6948 instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With the generated go client, the body response is read and closed inside the function, which is not returned. It is impossible to get the body from the returned value.
I suggest to not close the body and let the user do it with the returned value.
CC @antihax (2017/11) @grokify (2018/07) @kemokemo (2018/09) @bkabrda (2019/07)
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master