[python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...)#7154
Merged
spacether merged 2 commits intoOpenAPITools:masterfrom Aug 10, 2020
cjgibson:cjgibson/allow-float-timeout
Merged
[python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...)#7154spacether merged 2 commits intoOpenAPITools:masterfrom cjgibson:cjgibson/allow-float-timeout
spacether merged 2 commits intoOpenAPITools:masterfrom
cjgibson:cjgibson/allow-float-timeout
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
spacether
reviewed
Aug 7, 2020
modules/openapi-generator/src/main/resources/python/rest.mustache
Outdated
Show resolved
Hide resolved
spacether
reviewed
Aug 7, 2020
...ent/petstore/typescript-angular-v10-provided-in-root/builds/default/.openapi-generator/FILES
Outdated
Show resolved
Hide resolved
cjgibson
changed the title
Contributor
|
That error is unrelated to python or python-experimental because it is raised from petstore-okhttp-gson server testing |
spacether
approved these changes
Aug 10, 2020
Contributor
spacether
left a comment
spacether
left a comment
There was a problem hiding this comment.
Thank you for the PR! Looks good to me.
Contributor
Author
|
Awesome - thanks for the quick feedback and review here @spacether! Much appreciated. 😁 |
Contributor
|
You're welcome! Thank you for the fix 👍 |
jimschubert
added a commit
that referenced
this pull request
Aug 12, 2020
* master: (27 commits) [WIP][python-exp] Force camelization of imports (#7186) Fixes #6942: Added ability to prepend a basePath to typescript-redux-query generators (#6943) [Typescript] Import path is invalid in windows. (#7175) Fix JaxRS Spec generator additional model types (#7180) [python{,-experimental}] Obey floating point timeouts provided to RESTClientObject.request(...) (#7154) [C#] Switch the spec to OAS v3 from v2 (#7176) [Javascript] Fixing the handling of non primitive types in paramToString (#7171) (#7172) [typescript-node] Fix invalid type when using node@10 and ES5 (#7133) Minor fix to github workflow badge [gradle] Enabling up-to-date checks and gradle caching for openapigenerator tasks (#6716) feat(csharp-netcore): Adding response headers to the ApiException (#7169) [ci] Verify supported JDK versions on master push (#7085) Issue #6830: Java server - Add getter to ApiException templates (#7150) update kotlin samples [Kotlin] Make ApiClient in jvm-retrofit2 be able to use own OkHttpClient (#6999) Sttp - wrap query params (#6884) Add a link to https://medium.com/@everisBrasil blog post (#7160) [C#][netcore] fix regular expression when it contains double quotes (#7147) remove duplicated cancellationToken in comment (#7148) update samples ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows passing of a fractional number of seconds as a timeout when making network requests through the
RESTClientObject. Currently timeout durations provided as afloatare silently ignored instead of being enforced:RESTClientObject timeout behavior
The underlying call to
urllib3.PoolManager.requestwill happily accept afloattimeout duration, as shown:urllib3 timeout behavior
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterFixes: kubernetes-client/python#1069
@spacether