[core] Use canonical path for template dir#7388
Merged
jimschubert merged 1 commit intoOpenAPITools:masterfrom Sep 14, 2020
Merged
[core] Use canonical path for template dir#7388jimschubert merged 1 commit intoOpenAPITools:masterfrom
jimschubert merged 1 commit intoOpenAPITools:masterfrom
Conversation
|
👍 Thanks for opening this issue! The team will review the labels and make any necessary changes. |
Contributor
Author
|
cc @jimschubert as you authored the PR #6598 |
Member
|
cc @OpenAPITools/generator-core-team as well |
30a335d to
9f281e5
Compare
Contributor
Author
|
Friendly bump on this one, it's currently preventing us from upgrading openapi-generator to the master and enjoying the latest 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the canonical path of
templateDirinstead of absolute path in order to get rid of..when specifying a relative templateDir like-t ../../templatesin the command line, and avoid raising the new exception introduced in #6598:IllegalArgumentException("Template location must be constrained to template directory.")PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master