[rust-server] Fix server example on non-Linux#7399
Merged
richardwhiuk merged 4 commits intoOpenAPITools:masterfrom Oct 5, 2020
mattdowdell:patch-1
Merged
[rust-server] Fix server example on non-Linux#7399richardwhiuk merged 4 commits intoOpenAPITools:masterfrom mattdowdell:patch-1
richardwhiuk merged 4 commits intoOpenAPITools:masterfrom
mattdowdell:patch-1
Conversation
The server example is broken because it tries to import `use openssl::ssl::SslAcceptorBuilder;` unconditionally when it won't be present on MacOS, Windows or iOS and then conditionally provides `create` causing compile errors on the aforementioned platforms. To fix, we simply move the condition from the function to the import and all is happy again :)
Contributor
Author
|
Member
|
Thanks for the PR. I've merged the latest master into this branch. Let's see if that fixes the CI failures. |
richardwhiuk
approved these changes
Oct 5, 2020
Contributor
richardwhiuk
left a comment
There was a problem hiding this comment.
All looks good to me.
Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The server example is broken because it tries to import
use openssl::ssl::SslAcceptorBuilder;unconditionally when it won't be present on MacOS, Windows or iOS and then conditionally providescreatecausing compile errors on the aforementioned platforms which try to unconditionally import said function inmain.rs.To fix, we simply move the condition from the function to the import and all is happy again :)
To verify, generate the code from any spec, then attempt to use the server example on one of the problem platforms.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.mastercc @frol @farcaller @richardwhiuk @paladinzh for review.