Skip to content

[C#][netcore] Add anyOf support#7801

Merged
wing328 merged 2 commits intomasterfrom
csharp-anyof
Oct 27, 2020
Merged

[C#][netcore] Add anyOf support#7801
wing328 merged 2 commits intomasterfrom
csharp-anyof

Conversation

@wing328
Copy link
Member

@wing328 wing328 commented Oct 25, 2020

  • Add anyOf support
  • Add missing docstring in a method

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@auto-labeler
Copy link

auto-labeler bot commented Oct 25, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@wing328 wing328 marked this pull request as ready for review October 27, 2020 06:02
@wing328 wing328 added this to the 5.0.0 milestone Oct 27, 2020
@wing328 wing328 merged commit 042fc81 into master Oct 27, 2020
@wing328
Copy link
Member Author

wing328 commented Oct 27, 2020

Sorry forgot to cc @mandrean (2017/08) @frankyjuang (2019/09) @shibayan (2020/02)

@wing328 wing328 deleted the csharp-anyof branch October 27, 2020 09:02
@4brunu 4brunu mentioned this pull request Feb 17, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant