Fix a few issues with go examples generation#7873
Merged
wing328 merged 17 commits intoOpenAPITools:masterfrom Nov 12, 2020
Merged
Fix a few issues with go examples generation#7873wing328 merged 17 commits intoOpenAPITools:masterfrom
wing328 merged 17 commits intoOpenAPITools:masterfrom
Conversation
This fixes a bunch of issues seen when generating go examples, namely - Numbers aren't casted to the right type - The time import is missing - Enums are treated as regular models
Contributor
Author
bkabrda
suggested changes
Nov 10, 2020
Contributor
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Looks really good, I just left couple minor comments inline to look at and address.
| } else if (codegenParameter.isMap) { | ||
| return codegenParameter.dataType + "{ \"key\": " + constructExampleCode(codegenParameter.items, modelMaps, processedModelMap) + "}"; | ||
| String prefix = codegenParameter.dataType; | ||
| String dataType = codegenParameter.dataType.substring(13); // map[string][] |
Contributor
There was a problem hiding this comment.
I'd suggest using "map[string][]".length() instead of 13. It's self-commenting and also prevents off-by-one errors. (There are couple instances of this, so please fix them all)
Contributor
Author
There was a problem hiding this comment.
Good thinking. I tried removeStart which seems even more clear, let me know if it works.
modules/openapi-generator/src/main/resources/go/api_doc.mustache
Outdated
Show resolved
Hide resolved
wing328
reviewed
Nov 22, 2020
modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/GoClientCodegen.java
Show resolved
Hide resolved
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of issues seen when generating go examples, namely
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master