[typescript-fetch] Allow to generate client without runtime checks#7894
Merged
macjohnny merged 4 commits intoOpenAPITools:masterfrom Nov 16, 2020
Merged
Conversation
Contributor
Author
|
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) |
Contributor
Author
|
If anyone can tell me if that's normal but the Java11 tests failed on |
- Generates all the models in a same file to avoid import complexity - Extract interfaces creator templates to reuse them
a81ba2b to
20b2f15
Compare
Open
6 tasks
Member
|
@acote-coveo thanks for your contribution |
6 tasks
Contributor
|
This doesn't work for me. Has it regressed? |
Member
|
@ffMathy did you set the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterI tried to use the typescript-fetch client with a spec that use union and saw that the types were good but the serialization/deserialization wasn't working pretty well.
The main problems are:
OneTypeorArray<Type1 | Type2 | string | boolean>)Example of what was badly generated
Below, we have a list of
oneOfdata types to map. Thus, to serialize them, we calldataType[ToJson]. We then end up with something likeboolean | AdvancedGenerateQueryFieldParameterToJsonSimple solution
A bit like what has been done with the Axios client,I added a flag that allows to generate a client without any runtime checks.
So we simplify the client to only generate the interfaces and cast the input/output to these.
For a small effort, we now are able to have a simple client that compiles.
On a subsequent pull request, I would like to address the problem of unions by also providing serialization/deserialization (runtime checks).