Merged
Conversation
6 tasks
Contributor
|
What happened to the other generators? 😢
|
Member
Author
|
@ulgens when the If you need some good starting points to add back the support, please let me know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Based on #7900 so credits go to @spacether)
This PR makes these generator changes
pythonbecomespython-legacypython-experimentalbecomespythonWe are switching the python-experimental generator in as our stable python generator because it has significantly better composed schema support, many new features, and uses python3 only.
Some python (python-experimental) features
Also I improved string regex handling in python-legacy.
For python-legacy using the openapi (v3) spec sample tests of models have been regenerated and for non composed models, python-legacy now has auto-written tests that test instantiating a model instance with optional, and optional + required arguments. The regex fix was needed to get these tests passing.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.masterCore Team
@wing328 (2015/07) ❤️
@jimschubert (2016/05) ❤️
@cbornet (2016/05)
@ackintosh (2018/02) ❤️
@jmini (2018/04) ❤️
@etherealjoy (2019/06)
@spacether (2020/05)