Skip to content

[C][Client] Fix memory leak when the type of query parameter in request url is integer or boolean#8096

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-query-memleak
Dec 5, 2020
Merged

[C][Client] Fix memory leak when the type of query parameter in request url is integer or boolean#8096
wing328 merged 1 commit intoOpenAPITools:masterfrom
ityuhui:yh-query-memleak

Conversation

@ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Dec 4, 2020

This defect is introduced by my previous PR #6652.

At that PR, I converted the integer/boolean query parameter to a string, but forgot to free the memory of this string before the function returns, this will cause memory leak.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • If contributing template-only or documentation-only changes which will change sample output, build the project beforehand.
  • Run the shell script ./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master
  • Copy the technical committee to review the pull request if your PR is targeting a particular programming language.

@wing328 @zhemant @michelealbano

@auto-labeler
Copy link

auto-labeler bot commented Dec 4, 2020

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@ityuhui ityuhui closed this Dec 4, 2020
@ityuhui ityuhui changed the title [C][Client] Fix memory leak when the type of query parameter in reque… [C][Client] Fix memory leak when the type of query parameter in request url is integer or boolean Dec 4, 2020
@ityuhui ityuhui reopened this Dec 4, 2020
@wing328 wing328 added this to the 5.0.0 milestone Dec 5, 2020
@wing328 wing328 merged commit bac913f into OpenAPITools:master Dec 5, 2020
@ityuhui
Copy link
Contributor Author

ityuhui commented Dec 5, 2020

Thanks @wing328

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants