Fix handling of free-form query parameters with Java Resttemplate#8353
Closed
gpspatacean wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Fix handling of free-form query parameters with Java Resttemplate#8353gpspatacean wants to merge 1 commit intoOpenAPITools:masterfrom
gpspatacean wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
Author
|
Tech comm: And @nbruno for Resttemplate ownership |
Author
|
These changes were merged under #10428 . Closing this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for (#8352).
On codegen level, it seems the parsing of the spec file is correct.
The problem seems to be on the template level: the method
ApiClient.parameterToMultiValueMap(...), although receives the free form map as parameter, it doesn't have any kind of handling for it.Input spec file for repro/validation and details on the ticket.
PR checklist
./bin/generate-samples.shto update all Petstore samples related to your fix. This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master. These must match the expectations made by your contribution. You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example./bin/generate-samples.sh bin/configs/java*. For Windows users, please run the script in Git BASH.master,5.1.x,6.0.x