[JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient#882
Merged
jmini merged 7 commits intoOpenAPITools:masterfrom Aug 25, 2018
hfgbarrigas:custom_webclient
Merged
[JAVA][Webclient] Add constructor to allow custom WebClient to be passed into ApiClient#882jmini merged 7 commits intoOpenAPITools:masterfrom hfgbarrigas:custom_webclient
jmini merged 7 commits intoOpenAPITools:masterfrom
hfgbarrigas:custom_webclient
Conversation
jmini
approved these changes
Aug 23, 2018
Member
jmini
left a comment
jmini
left a comment
There was a problem hiding this comment.
This looks good to me, I let some time for others to review.
jmini
changed the title
Contributor
Author
|
Edit: Actually call init() to properly add authentications. |
Member
|
I have merged |
Member
|
Thank you a lot for this contribution |
Member
|
@hfgbarrigas thanks for the PR, which has been included in the v3.2.3 release: https://twitter.com/oas_generator/status/1035200785066254336 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…sed into ApiClient (OpenAPITools#882) * add constructor to allow custom webclient to be passed into ApiClient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the PR
Add apiclient constructor allowing custom webclient to be used.
@bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)
Fixes #874