Fix python example list#8877
Merged
spacether merged 3 commits intoOpenAPITools:masterfrom Mar 10, 2021
Merged
Conversation
jirikuncar
approved these changes
Mar 3, 2021
Contributor
Author
|
@taxpon @frol @mbohlool @cbornet @kenjones-cisco @tomplus @Jyhess @arun-nalla @spacether 🙇 |
spacether
reviewed
Mar 3, 2021
Contributor
There was a problem hiding this comment.
Why are we not seeing a sample change?
Could you add a test sample which uses this code path?
Contributor
Author
There was a problem hiding this comment.
I added a test sample, and it made me realize it didn't fix it the way I expected it to be fixed. I changed the code, let me know if it makes sense.
4a708a7 to
e97d6fc
Compare
spacether
reviewed
Mar 6, 2021
...esources/3_0/python/petstore-with-fake-endpoints-models-for-testing-with-http-signature.yaml
Outdated
Show resolved
Hide resolved
9178eab to
d40af38
Compare
Contributor
|
@therve could you rebase on master? |
d40af38 to
b8cee6c
Compare
b8cee6c to
5918fc8
Compare
Contributor
|
circleci dart issue is a know issue and is not caused by this pr |
spacether
approved these changes
Mar 10, 2021
Contributor
spacether
left a comment
There was a problem hiding this comment.
Thank you for your PR and for adding the tests. This looks good!
CI errors are unrelated to this PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes python list examples on models by not generating the example when we have model objects, and adding the missing closing character when we don't.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x