[dart] Fix api client deserialization for json_serializable#8882
Merged
wing328 merged 11 commits intoOpenAPITools:masterfrom Mar 11, 2021
Merged
Conversation
kuhnroyal
reviewed
Mar 3, 2021
samples/client/petstore/dart2/petstore_client_lib/lib/api/user_api.dart
Outdated
Show resolved
Hide resolved
agilob
commented
Mar 4, 2021
samples/openapi3/client/petstore/dart2/petstore_client_lib_fake/lib/api/fake_api.dart
Outdated
Show resolved
Hide resolved
Contributor
Author
|
I think this is too much of a change and should be more conditional for now... brb |
Contributor
Author
|
Class.fromJson is only used in json_serializable not for native |
…to dart-json-serializable-api-client-fix-deserialization-of-objects
Contributor
Author
|
@kuhnroyal bump |
kuhnroyal
reviewed
Mar 10, 2021
...napi3/client/petstore/dart2/petstore_client_lib_fake/lib/api/fake_classname_tags123_api.dart
Outdated
Show resolved
Hide resolved
b546fd7 to
7759ae1
Compare
…to dart-json-serializable-api-client-fix-deserialization-of-objects
Contributor
Author
|
Failure in: |
Contributor
|
Ya, #8947 fixed this on master. Just needs a rebuild probably. |
Contributor
Author
|
Yup, passed now after pulling master |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Oh boy I hope this worksIt works
@kuhnroyal