Sets model.additionalProperties for composed schemas#9031
Closed
spacether wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
Sets model.additionalProperties for composed schemas#9031spacether wants to merge 1 commit intoOpenAPITools:masterfrom
spacether wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
… supportsAdditionalPropertiesWithComposedSchema is true, tests updated for v2 and v3 specs
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sets model.additionalProperties for composed schemas
No generator use this data yet.
Tests updated for v2 and v3 additionalProperties checking
v2 specs, legacy behavior (disallowAdditionalPropertiesIfNotPresent = True, supportsAdditionalPropertiesWithComposedSchema = False)
v2 specs, new behavior (disallowAdditionalPropertiesIfNotPresent = False, supportsAdditionalPropertiesWithComposedSchema=True)
This update will be used in the python generator in #8802
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x