[Java] add jackson annotations to setters#9041
Merged
wing328 merged 2 commits intoOpenAPITools:masterfrom Mar 30, 2021
Merged
Conversation
Contributor
Author
|
Looks like this creates an issue when @JsonProperty(JSON_PROPERTY_NULLABLE_SHAPE)
public void setNullableShape_JsonNullable(JsonNullable<NullableShape> nullableShape) {
this.nullableShape = nullableShape;
}
@JsonProperty(JSON_PROPERTY_NULLABLE_SHAPE)
@JsonInclude(value = JsonInclude.Include.USE_DEFAULTS)
public void setNullableShape(NullableShape nullableShape) {
this.nullableShape = JsonNullable.<NullableShape>of(nullableShape);
}two possible solutions are:
|
Contributor
Author
|
I implemented option two. |
Contributor
Author
|
@wing328 any chance of getting this into the next minor release? |
wing328
approved these changes
Mar 30, 2021
Member
wing328
left a comment
There was a problem hiding this comment.
LGTM but I've not tested it locally
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6856
Jackson deserialization fails with the message "Problem deserializing 'setterless' property" if json keys are not in camel case. This commit fixes that problem by adding
@JsonPropretyto setters.PR checklist
master@bbdouglas @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger @karismann @Zomzog @lwlee2608 @nmuesch