Skip to content

[python] fix custom model template feature#9118

Merged
spacether merged 3 commits intoOpenAPITools:masterfrom
spacether:fix_python_custom_model_template_feature
Mar 28, 2021
Merged

[python] fix custom model template feature#9118
spacether merged 3 commits intoOpenAPITools:masterfrom
spacether:fix_python_custom_model_template_feature

Conversation

@spacether
Copy link
Contributor

@spacether spacether commented Mar 28, 2021

Fix python custom model template feature
I verified locally that using only a custom model template works with this update

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@auto-labeler
Copy link

auto-labeler bot commented Mar 28, 2021

👍 Thanks for opening this issue!
🏷 I have applied any labels matching special text in your issue.

The team will review the labels and make any necessary changes.

@spacether spacether changed the title Fix [python] custom model template feature [python] fix custom model template feature Mar 28, 2021
@spacether
Copy link
Contributor Author

CircleCI error in DartDioPetstoreClientLibFakeTests is unrelated to this change

@spacether spacether added this to the 5.1.1 milestone Mar 28, 2021
@spacether spacether merged commit fe52529 into OpenAPITools:master Mar 28, 2021
@spacether spacether deleted the fix_python_custom_model_template_feature branch February 6, 2022 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG][Python] Adding custom model template with Python generator throws exception

1 participant

Comments