Skip to content

[Codegen] Add hasDefaultResponse property#9203

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
aymanbagabas:add-has-default-response
Apr 28, 2021
Merged

[Codegen] Add hasDefaultResponse property#9203
wing328 merged 1 commit intoOpenAPITools:masterfrom
aymanbagabas:add-has-default-response

Conversation

@aymanbagabas
Copy link
Contributor

@aymanbagabas aymanbagabas commented Apr 7, 2021

Check if there's a default response in specs

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@aymanbagabas
Copy link
Contributor Author

aymanbagabas commented Apr 7, 2021

Used in #8515

@4brunu @wing328

@4brunu
Copy link
Contributor

4brunu commented Apr 7, 2021

I don't have much knowledge of CodegenOperation.java so let's wait for the @wing328 review.

@aymanbagabas aymanbagabas force-pushed the add-has-default-response branch from 1ba2b4a to f2ddce1 Compare April 7, 2021 16:52
@aymanbagabas aymanbagabas force-pushed the add-has-default-response branch from f2ddce1 to e0cbd24 Compare April 8, 2021 17:05
Check if there's a default response in the specs.
@aymanbagabas aymanbagabas force-pushed the add-has-default-response branch from e0cbd24 to 531a660 Compare April 9, 2021 01:02
@wing328
Copy link
Member

wing328 commented Apr 27, 2021

cc @OpenAPITools/generator-core-team

@wing328
Copy link
Member

wing328 commented Apr 28, 2021

Looks good to me.

@wing328 wing328 merged commit 057c108 into OpenAPITools:master Apr 28, 2021
@wing328 wing328 added this to the 5.1.1 milestone Apr 28, 2021
@PirvuCatalin
Copy link

Is this actually working? I cannot specify this value, what type of property? Documentation is also not updated... More details, would you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

Comments