[Kotlin Multiplatform] Update and fixes#9232
Closed
DevSrSouza wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
[Kotlin Multiplatform] Update and fixes#9232DevSrSouza wants to merge 2 commits intoOpenAPITools:masterfrom
DevSrSouza wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
…x.serialization 1.1.0 * Fix `private` keyword not being handle as a reservedWords * Fix enum serialization generation * Migrate gradle build to Kotlin DSL
DevSrSouza
changed the title
wing328
reviewed
Apr 16, 2021
| } else { | ||
| supportingFiles.add(new SupportingFile("build.gradle.mustache", "", "build.gradle")); | ||
| supportingFiles.add(new SupportingFile("settings.gradle.mustache", "", "settings.gradle")); | ||
| } |
Member
There was a problem hiding this comment.
@DevSrSouza I would suggest file a separate PR for this particular change.
What about adding an option to let user choose between gradle build and Kotlin DSL as I could imagine not every users want Kotlin DSL?
wing328
reviewed
Apr 16, 2021
| * {{{description}}} | ||
| * Values: {{#allowableValues}}{{#enumVars}}{{&name}}{{^-last}},{{/-last}}{{/enumVars}}{{/allowableValues}} | ||
| */ | ||
| {{#multiplatform}}@Serializable{{/multiplatform}} |
Member
There was a problem hiding this comment.
Suggested change to avoid blank line in the output:
{{#multiplatform}}
@Serializable
{{/multiplatform}}
nickbw2003
pushed a commit
to myworkout/KaMPKit
that referenced
this pull request
Apr 30, 2021
This adds the kotlin-api-client to the POC so that we should be able to make API calls. The API client needed to be generated based on the dependency updates of the openapi-client-generator which didn't make it to an official release yet. Therefore it was not added as a Git submodule. More information about the changes on the generator project here: OpenAPITools/openapi-generator#9232
nickbw2003
pushed a commit
to myworkout/KaMPKit
that referenced
this pull request
May 3, 2021
This adds the kotlin-api-client to the POC so that we should be able to make API calls. The API client needed to be generated based on the dependency updates of the openapi-client-generator which didn't make it to an official release yet. Therefore it was not added as a Git submodule. More information about the changes on the generator project here: OpenAPITools/openapi-generator#9232
|
Looks like updating @DevSrSouza , @wing328 Is there anything blocking this PR from merging? |
Contributor
|
Will we see some changes from @DevSrSouza or this being merged? Else can we open a new PR with the above mentioned adjustments? |
Merged
5 tasks
Closed
5 tasks
Member
|
Closed via #9755 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kotlin: 1.4.32
Ktor: 1.5.3
Kotlinx.serialization: 1.1.0
privatekeyword not being handle as a reservedWordsPR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x@jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m