Skip to content

[typescript-angular] Fix undefined query param when queryParamObjectFormat=json#9657

Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom
oaklandcorp:fix_issue7619
Jun 3, 2021
Merged

[typescript-angular] Fix undefined query param when queryParamObjectFormat=json#9657
macjohnny merged 1 commit intoOpenAPITools:masterfrom
oaklandcorp:fix_issue7619

Conversation

@djnalluri
Copy link
Contributor

Fixes #7619

Attempting to pass an object as a query parameter while queryParamObjectFormat=json currently results in the key being set to undefined. This PR ensures the key is always provided when the JSON object format is used.

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Technical Committee
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)

Copy link
Member

@macjohnny macjohnny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@macjohnny macjohnny merged commit 972ad56 into OpenAPITools:master Jun 3, 2021
@macjohnny macjohnny added this to the 5.2.0 milestone Jun 3, 2021
@Traksewt
Copy link

Traksewt commented Jun 10, 2021

@macjohnny Is this bug fix getting backported to a new 5.1.2, as I cannot see how to install 5.2 pre-release from the cli? Waiting for this fix.thx

@macjohnny
Copy link
Member

The fix is not backported, but you can download the snapshot JAR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] [typescript-angular] Query param key is undefined when using queryParamObjectFormat=json

3 participants