[typescript-angular] Fix undefined query param when queryParamObjectFormat=json#9657
Merged
macjohnny merged 1 commit intoOpenAPITools:masterfrom Jun 3, 2021
oaklandcorp:fix_issue7619
Merged
[typescript-angular] Fix undefined query param when queryParamObjectFormat=json#9657macjohnny merged 1 commit intoOpenAPITools:masterfrom oaklandcorp:fix_issue7619
macjohnny merged 1 commit intoOpenAPITools:masterfrom
oaklandcorp:fix_issue7619
Conversation
|
@macjohnny Is this bug fix getting backported to a new 5.1.2, as I cannot see how to install 5.2 pre-release from the cli? Waiting for this fix.thx |
Member
|
The fix is not backported, but you can download the snapshot JAR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #7619
Attempting to pass an object as a query parameter while queryParamObjectFormat=json currently results in the key being set to undefined. This PR ensures the key is always provided when the JSON object format is used.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.xTechnical Committee
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02)