Skip to content

[swift][client] make swift 5 generator stable#9666

Merged
wing328 merged 1 commit intoOpenAPITools:masterfrom
4brunu:feature/swift5-generator-stable
Jun 7, 2021
Merged

[swift][client] make swift 5 generator stable#9666
wing328 merged 1 commit intoOpenAPITools:masterfrom
4brunu:feature/swift5-generator-stable

Conversation

@4brunu
Copy link
Contributor

@4brunu 4brunu commented Jun 3, 2021

I think it's time to declare swift 5 generator as stable.
It's been out for a year and half, without major issues, so I think it's time now.

This PR should only be merged after #9625

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jgavris (2017/07) @ehyche (2017/08) @Edubits (2017/09) @jaz-ah (2017/09) @4brunu (2019/11)

@wing328
Copy link
Member

wing328 commented Jun 7, 2021

Sounds good to me too.

@wing328 wing328 added this to the 5.2.0 milestone Jun 7, 2021
@wing328 wing328 merged commit 8c268c9 into OpenAPITools:master Jun 7, 2021
@4brunu 4brunu deleted the feature/swift5-generator-stable branch June 7, 2021 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants