Skip to content

[#9805][Kotlin][multiplatform] Make the template work with Kotlin 1.5.x#9827

Closed
krzema12 wants to merge 2 commits intoOpenAPITools:masterfrom
krzema12:9805-update-Kotlin-multiplatform-to-1.5.10
Closed

[#9805][Kotlin][multiplatform] Make the template work with Kotlin 1.5.x#9827
krzema12 wants to merge 2 commits intoOpenAPITools:masterfrom
krzema12:9805-update-Kotlin-multiplatform-to-1.5.10

Conversation

@krzema12
Copy link
Copy Markdown
Contributor

Issue

[BUG][kotlin-client][multiplatform] "NoSuchMethodError" in runtime when starting ktor server with Kotlin 1.5.10 · Issue #9805 · OpenAPITools/openapi-generator (#9805)

Details

The goal of this change is to make Kotlin multiplatform template work with the newest Kotlin version (1.5.10).
Without these changes, consuming generated module from a Kotlin 1.5-based module with a Ktor server
results in a runtime exception when installing the JSON feature.

My guess is that due to some breaking changes kotlinx.serialization. For consistency, all kotlinx libraries were
updated, to adhere to the recommended versions mentioned here: https://kotlinlang.org/docs/releases.html#release-details

This change is meant to be as simple as possible - just bumping the versions and making minimal necessary adjustments.
I'm planning to introduce other changes (remove unneeded stuff, address warnings which will become errors in the future, add end-to-end tests if not present, and so on) in separate PR(s).

Testing done

  • ran integration tests (mvn integration-test -f samples/client/petstore/kotlin-multiplatform)
  • created an entry point in the generated sample project and made a few test calls. I didn't test all APIs, it was rather meant to be a smoke test

To be clarified

  • are there any end-to-end tests that actually try to call the Petstore service with the generated module?
  • how to ensure there are no regressions in other Kotlin templates that reuse the shared pieces of template?
  • is master the right target branch for this change? The policy is confusing to me

I'd expect there are some tests ran by the CI that will address my above concerns. That's why I'm posting this PR anyway, to see what workflows GitHub will trigger, and to get feedback from the community.

FYI

Kotlin technical committee: @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.1.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

krzema12 added 2 commits June 22, 2021 14:00
…th related libraries

The immediate goal of this commit is update the mentioned template to
work with Kotlin 1.5.x. Currently when consuming the genrated module
using Kotlin 1.3.50 from a Kotlin 1.5.x module with Ktor, starting the
Ktor server fails in runtime.
@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Jun 22, 2021

I think this PR changes some things that will conflict with #9755

@krzema12
Copy link
Copy Markdown
Contributor Author

@4brunu thanks for referencing the PR! Indeed, my PR seems to be actually not needed once that one is merged. I'll engage in reviewing it.

@4brunu
Copy link
Copy Markdown
Contributor

4brunu commented Jun 22, 2021

Thanks, your review on the other PR will be helpful 👍

@krzema12
Copy link
Copy Markdown
Contributor Author

Closing in favor of #9755 which is more correct and comprehensive.

@krzema12 krzema12 closed this Jun 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants