[#9805][Kotlin][multiplatform] Make the template work with Kotlin 1.5.x#9827
Closed
krzema12 wants to merge 2 commits intoOpenAPITools:masterfrom
Closed
[#9805][Kotlin][multiplatform] Make the template work with Kotlin 1.5.x#9827krzema12 wants to merge 2 commits intoOpenAPITools:masterfrom
krzema12 wants to merge 2 commits intoOpenAPITools:masterfrom
Conversation
…th related libraries The immediate goal of this commit is update the mentioned template to work with Kotlin 1.5.x. Currently when consuming the genrated module using Kotlin 1.3.50 from a Kotlin 1.5.x module with Ktor, starting the Ktor server fails in runtime.
Contributor
|
I think this PR changes some things that will conflict with #9755 |
Contributor
Author
|
@4brunu thanks for referencing the PR! Indeed, my PR seems to be actually not needed once that one is merged. I'll engage in reviewing it. |
Contributor
|
Thanks, your review on the other PR will be helpful 👍 |
Contributor
Author
|
Closing in favor of #9755 which is more correct and comprehensive. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
[BUG][kotlin-client][multiplatform] "NoSuchMethodError" in runtime when starting ktor server with Kotlin 1.5.10 · Issue #9805 · OpenAPITools/openapi-generator (#9805)
Details
The goal of this change is to make Kotlin multiplatform template work with the newest Kotlin version (1.5.10).
Without these changes, consuming generated module from a Kotlin 1.5-based module with a Ktor server
results in a runtime exception when installing the JSON feature.
My guess is that due to some breaking changes kotlinx.serialization. For consistency, all kotlinx libraries were
updated, to adhere to the recommended versions mentioned here: https://kotlinlang.org/docs/releases.html#release-details
This change is meant to be as simple as possible - just bumping the versions and making minimal necessary adjustments.
I'm planning to introduce other changes (remove unneeded stuff, address warnings which will become errors in the future, add end-to-end tests if not present, and so on) in separate PR(s).
Testing done
mvn integration-test -f samples/client/petstore/kotlin-multiplatform)To be clarified
masterthe right target branch for this change? The policy is confusing to meI'd expect there are some tests ran by the CI that will address my above concerns. That's why I'm posting this PR anyway, to see what workflows GitHub will trigger, and to get feedback from the community.
FYI
Kotlin technical committee: @jimschubert, @dr4ke616, @karismann, @Zomzog, @andrewemery, @4brunu, @yutaka0m
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.1.x,6.0.x