[typescript] fix issue with special characters#9940
Closed
mayrmax wants to merge 1 commit intoOpenAPITools:masterfrom
Closed
[typescript] fix issue with special characters#9940mayrmax wants to merge 1 commit intoOpenAPITools:masterfrom
mayrmax wants to merge 1 commit intoOpenAPITools:masterfrom
Conversation
80d50f6 to
2665f4f
Compare
Author
|
Seems like this leaves the breaking @ in, maybe |
Fix issue where special characters such as @ get stripped.
2665f4f to
7b4083c
Compare
Author
amakhrov
reviewed
Jul 19, 2021
Contributor
amakhrov
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
A few thoughts:
- Could you please provide examples of the code generated before and after this change?
- Let's add some tests verifying the changed behavior
- I'm slightly concerned that with this change TS generators will generally produce uncompilable code, since models are generated without quoting. We probably need to update all templates to account for unsafe identifiers:
// before
interface SomeModel {
@unsafeName: string;
}
// after
interface SomeModel {
'@unsafeName': string;
}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issue where special characters such as @ get stripped in the abstract typescript options. This changes affects all typescript generators.
Fixes:
@TiFu @taxpon @petejohansonxo @amakhrov
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master,5.3.x,6.0.x