[Build] Update pyyaml version to 6.0.0 and conan to 1.60.1
#31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `AttributeError: cython_source` when trying to install via `pyyaml` 6+, however `conan` `1.60.1` only supports `6.0.0` explicitly, so we have to pin at that older version. See: yaml/pyyaml#601 Signed-off-by: Tom Cowland <tom@foundry.com>
foundrytom
changed the title
pyyaml version to 6.0.1pyyaml version to 6.0.0 and conan to 1.60.1
elliotcmorris
approved these changes
Jul 18, 2023
Contributor
elliotcmorris
left a comment
elliotcmorris
left a comment
There was a problem hiding this comment.
Ty for figuring this out. Hope it works.
Not the most comfortable thing in the world to be stuck on a specific version, did you read if there are plans to unstuck this upstream?
Contributor
Author
I guess it depends on the Conan policy to back-port updates to 1.x, we may have to migrate to 2 long term 🤔 need to go hunt what they're saying about all that. |
feltech
approved these changes
Jul 18, 2023
Member
feltech
left a comment
feltech
left a comment
There was a problem hiding this comment.
Unfortunate, but seems like the best solution for now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
AttributeError: cython_sourcewhen trying to install.see: yaml/pyyaml#601
So much for pinning deps :)