[Core] Use frozenset for Python kTraitSet #90
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes OpenAssetIO#55. Define the Python Specifications trait set using a `frozenset` so it can be hashed. Simplifies switching on trait set in manager implementations in Python, where a handler map is a nice way to structure code. I.e. a `frozenset` can be used as a dictionary key. Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
force-pushed
the
work/55-frozensetForTraitSet
branch
from
8dd0317 to
aa01b95
Compare
foundry-markf
approved these changes
Aug 19, 2024
foundry-markf
left a comment
foundry-markf
left a comment
There was a problem hiding this comment.
Had to do similar when wanting to use a set as a hash or a dict key, so LTGM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55. Define the Python Specifications trait set using a
frozensetso it can be hashed. Simplifies switching on trait set in manager implementations in Python, where a handler map is a nice way to structure code. I.e. afrozensetcan be used as a dictionary key.