Use OpenAssetIO context from manager #47
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Context instance is passed into every API method. The Context may bundle arbitrary state from the manager. In order for the Context to be created with the appropriate state by the manager, the host is required to construct a Context object using the `Manager.createContext()` method. However, we were not doing that and instead constructed the Context directly, which should never be done (other than for trivial cases e.g. unit tests). Signed-off-by: David Feltell <david.feltell@foundry.com>
feltech
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Context instance is passed into every API method. The Context may bundle arbitrary state from the manager. In order for the Context to be created with the appropriate state by the manager, the host is required to construct a Context object using the
Manager.createContext()method. However, we were not doing that and instead constructed the Context directly, which should never be done (other than for trivial cases e.g. unit tests).Note that this cannot be unit tested easily - currently our mock manager BAL does not make use of the Context.