Skip to content

Conversation

@kjappelbaum
Copy link
Collaborator

@kjappelbaum kjappelbaum commented Mar 13, 2023

originally opened in #72

Dropped the addition of the examples as it was inconsistent with the transform.py approach some contributors used.

@kjappelbaum kjappelbaum changed the title Add uris field for identifiers feat: Add uris field for identifiers Mar 13, 2023
@MicPie MicPie merged commit 7f82491 into main Mar 13, 2023
@MicPie MicPie deleted the ml-evs/main branch March 13, 2023 19:17
@MicPie
Copy link
Contributor

MicPie commented Mar 13, 2023

Thank you all!

MicPie added a commit that referenced this pull request Mar 14, 2023
* Add `uris` field for identifiers

* Linting

* update valdation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: fix typo

---------

Co-authored-by: Matthew Evans <git@ml-evs.science>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Pieler <Michael.Pieler@Gmail.com>
MicPie added a commit that referenced this pull request Mar 14, 2023
MicPie added a commit that referenced this pull request Mar 14, 2023
* Add `uris` field for identifiers

* Linting

* update valdation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: fix typo

---------

Co-authored-by: Matthew Evans <git@ml-evs.science>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Pieler <Michael.Pieler@Gmail.com>
MicPie added a commit that referenced this pull request Mar 14, 2023
MicPie added a commit that referenced this pull request Mar 14, 2023
MicPie added a commit that referenced this pull request Mar 16, 2023
* chore: run pre-commit in CI

* chore: rework datasets

* finish reworking ClinTox

* chore: continue cleanup

* chore: continue cleanup

* chore: continue cleaning

* update contribution guide

* fix optional deps

* update contribution guide

* update contribution guide

* chore: continue cleanup

* chore: continue cleanup

* chore: continue cleanup

* chore: continue cleanup

* chore: continue cleanup

* lint yaml

* feat: update CONTRIBUTING.md

* feat: remove duplicated split_col key

* feat: rm data/flashpoint/data_clean.csv

* feat: rm word

* fix: spaces data/cav3_t-type_calcium_channels_butkiewicz/meta.yaml

* fix: spaces data/choline_transporter_butkiewicz/meta.yaml

* fix: data/choline_transporter_butkiewicz/transform.py

* fix: data/choline_transporter_butkiewicz/transform.py 2

* fix: data/freesolv/transform.py

* fix: data/kcnq2_potassium_channel_butkiewicz/meta.yaml

* fix: data/kcnq2_potassium_channel_butkiewicz/transform.py

* fix: data/kcnq2_potassium_channel_butkiewicz/meta.yaml grammar

* fix: data/kcnq2_potassium_channel_butkiewicz/transform.py grammar

* fix: spaces data/ld50_zhu/meta.yaml

* fix: data/m1_muscarinic_receptor_antagonists_butkiewicz/meta.yaml

* fix: data/m1_muscarinic_receptor_antagonists_butkiewicz/transform.py

* fix data/orexin1_receptor_butkiewicz/meta.yaml

* fix data/orexin1_receptor_butkiewicz/transform.py

* fix: data/pampa_ncats/meta.yaml

* fix: data/potassium_ion_channel_kir2_1_butkiewicz/meta.yaml

* data/potassium_ion_channel_kir2_1_butkiewicz/transform.py

* fix: data/serine_threonine_kinase_33_butkiewicz/meta.yaml

* fix: data/serine_threonine_kinase_33_butkiewicz/transform.py

* feat: update .gitignore for vim

* feat: Add uris field for identifiers (#103)

* Add `uris` field for identifiers

* Linting

* update valdation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* feat: fix typo

---------

Co-authored-by: Matthew Evans <git@ml-evs.science>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Michael Pieler <Michael.Pieler@Gmail.com>

* Revert "feat: Add uris field for identifiers (#103)"

This reverts commit 0f766e5.

* Revert "Revert "feat: Add uris field for identifiers (#103)""

This reverts commit dff4331.

* fix: validation

* fix: validation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: Michael Pieler <Michael.Pieler@Gmail.com>
Co-authored-by: Matthew Evans <git@ml-evs.science>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants