add iupac goldbook #188
Merged
add iupac goldbook #188
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjappelbaum
reviewed
Apr 27, 2023
Collaborator
|
@MicPie is there still something you wanted to do? Otherwise, I'd add the text type and merge it |
kjappelbaum
reviewed
May 5, 2023
kjappelbaum
reviewed
May 5, 2023
kjappelbaum
requested changes
May 5, 2023
Collaborator
kjappelbaum
left a comment
kjappelbaum
left a comment
There was a problem hiding this comment.
Did you try to validate? I think it should have failed with OTHER?
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Co-authored-by: Kevin M Jablonka <32935233+kjappelbaum@users.noreply.github.com>
Contributor
Author
|
@MicPie todo: change to |
…tests run through
…tests run through for yaml
kjappelbaum
reviewed
May 16, 2023
| type: SMILES | ||
| description: SMILES | ||
| - id: compound_id | ||
| type: Other |
Collaborator
There was a problem hiding this comment.
Suggested change
| type: Other | |
| type: Other | |
| sample: false |
kjappelbaum
reviewed
May 16, 2023
| }, | ||
| { | ||
| "id": "compound_id", | ||
| "type": "Other", |
Collaborator
There was a problem hiding this comment.
Suggested change
| "type": "Other", | |
| "sample": False, | |
| "type": "Other", |
Collaborator
|
validation should probably work when merged in main |
kjappelbaum
approved these changes
May 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.