Skip to content
This repository was archived by the owner on Dec 5, 2025. It is now read-only.

Conversation

@OBarronCS
Copy link
Contributor

Proposed changes

The OpenCTIApiClient class constructor has some parameters that are internally passed to the Python requests libraries functions. ssl_verify is passed to the verify parameter of request of self.session.get and self.session.post. This PR corrects the type hint for ssl_verify - previously it was bool, however it can also be a str ("path to a CA_BUNDLE file or directory with certificates of trusted CAs"). It also provides type hints for the other untyped parameters.

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case - it's just a type hint, don't know if a test is relevant
  • I added/update the relevant documentation (either on github or on notion) - edited the inline doc string
  • Where necessary I refactored code to improve the overall quality

@SouadHadjiat SouadHadjiat added the community use to identify PR from community label Dec 10, 2024
@SamuelHassine SamuelHassine merged commit 53a2461 into OpenCTI-Platform:master Feb 13, 2025
aHenryJard pushed a commit to OpenCTI-Platform/opencti that referenced this pull request Nov 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

community use to identify PR from community

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants