Skip to content

Conversation

@labo-flg
Copy link
Member

@labo-flg labo-flg commented Sep 5, 2025

Proposed changes

  • new internal entity type Theme
  • default Light and Dark themes
  • ability to add more and manager theme from settings/customization
  • migration to have default Light and Dark, and implement current changed theme as new themes in DB

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@codecov
Copy link

codecov bot commented Sep 5, 2025

Codecov Report

❌ Patch coverage is 75.09025% with 69 lines in your changes missing coverage. Please review.
✅ Project coverage is 66.42%. Comparing base (b8d860a) to head (6616f96).
⚠️ Report is 1 commits behind head on release/current.

Files with missing lines Patch % Lines
.../opencti-graphql/src/modules/theme/theme-domain.ts 70.07% 41 Missing ⚠️
...encti-graphql/src/modules/theme/theme-converter.ts 17.85% 23 Missing ⚠️
...pencti-graphql/src/database/data-initialization.js 33.33% 2 Missing ⚠️
...latform/opencti-graphql/src/modules/theme/theme.ts 94.87% 2 Missing ⚠️
...encti-graphql/src/http/httpAuthenticatedContext.js 0.00% 1 Missing ⚠️
Additional details and impacted files
@@                 Coverage Diff                 @@
##           release/current   #12290      +/-   ##
===================================================
- Coverage            66.42%   66.42%   -0.01%     
===================================================
  Files                  760      766       +6     
  Lines                80238    80512     +274     
  Branches              8593     8614      +21     
===================================================
+ Hits                 53298    53480     +182     
- Misses               26940    27032      +92     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kedae Kedae force-pushed the master branch 2 times, most recently from a40e1ff to 6d4e1ed Compare September 24, 2025 17:17
@marieflorescontact marieflorescontact added the filigran team use to identify PR from the Filigran team label Sep 26, 2025
@esrevi esrevi force-pushed the issue/12190-custom-theme branch 3 times, most recently from 0655801 to 749b2dd Compare October 7, 2025 16:14
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX changed the base branch from master to release/current October 8, 2025 12:22
@esrevi esrevi requested a review from SouadHadjiat October 10, 2025 07:00
@esrevi esrevi marked this pull request as ready for review October 10, 2025 07:01
@esrevi esrevi requested a review from natalie-natsu October 13, 2025 10:05
@esrevi esrevi force-pushed the issue/12190-custom-theme branch from b03c44e to 75f0a50 Compare October 13, 2025 13:28
@SouadHadjiat
Copy link
Member

SouadHadjiat commented Oct 14, 2025

Issues found during testing :

  • If I export a theme and import it again -> error since the name already exists (OK) but if I change the name in the file and try to import it again, nothing happens, I need to navigate or refresh the page.
  • The url of settings is changed with params from themes query

Minor issues

  • Ordering of themes seem random, shouldn't we order by name or creation date ?

@esrevi esrevi force-pushed the issue/12190-custom-theme branch from cba4391 to 71e4c5e Compare October 14, 2025 16:57
@esrevi
Copy link
Member

esrevi commented Oct 15, 2025

Issues found during testing :

  • If I export a theme and import it again -> error since the name already exists (OK) but if I change the name in the file and try to import it again, nothing happens, I need to navigate or refresh the page.
  • The url of settings is changed with params from themes query

Minor issues

  • Ordering of themes seem random, shouldn't we order by name or creation date ?

@SouadHadjiat
The different feedbacks have been addressed, now:

  • the url should not be modified with the filters params
  • importing a same file is a limitation from the browsers, I added a workaround that should empty the input file, so you can re-import the same file, it should work now,
  • the themes are now ordered by creation date

@esrevi esrevi force-pushed the issue/12190-custom-theme branch 4 times, most recently from bd37168 to 5156fb5 Compare October 21, 2025 13:38
labo-flg and others added 3 commits October 23, 2025 09:10
This reverts commit 6fa7cf9

# Conflicts:
#	opencti-platform/opencti-front/lang/front/de.json
#	opencti-platform/opencti-front/lang/front/en.json
#	opencti-platform/opencti-front/lang/front/es.json
#	opencti-platform/opencti-front/lang/front/fr.json
#	opencti-platform/opencti-front/lang/front/ja.json
#	opencti-platform/opencti-front/lang/front/ko.json
#	opencti-platform/opencti-front/lang/front/zh.json
#	opencti-platform/opencti-front/src/private/components/settings/Settings.tsx
#	opencti-platform/opencti-front/src/public/LoginRoot.tsx
#	opencti-platform/opencti-front/src/public/PublicRoot.tsx
#	opencti-platform/opencti-front/src/public/components/Login.tsx
#	opencti-platform/opencti-front/src/public/components/PublicDataSharing.tsx
#	opencti-platform/opencti-graphql/src/generated/graphql.ts
#	opencti-platform/opencti-graphql/src/schema/internalObject.ts
@esrevi esrevi force-pushed the issue/12190-custom-theme branch from a819661 to 6616f96 Compare October 23, 2025 07:12
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX merged commit 827611e into release/current Oct 23, 2025
11 checks passed
@Gwendoline-FAVRE-FELIX Gwendoline-FAVRE-FELIX deleted the issue/12190-custom-theme branch October 23, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants