Skip to content

Conversation

@JeremyCloarec
Copy link
Contributor

@JeremyCloarec JeremyCloarec commented Oct 3, 2025

Proposed changes

  • add new internal queue too-large-bundle
  • add objects_max_refs config to worker.py
  • in worker, if item has too many dependencies, it is sent to the too-large-bundle queue instead of being ingested

client PR: OpenCTI-Platform/client-python#982
doc PR: OpenCTI-Platform/docs#360

Related issues

Checklist

  • I consider the submitted work as finished
  • I tested the code for its functionality
  • I wrote test cases for the relevant uses case (coverage and e2e)
  • I added/update the relevant documentation (either on github or on notion)
  • Where necessary I refactored code to improve the overall quality

Further comments

@JeremyCloarec JeremyCloarec added the multi-repository For contribution that requires PR in several repository label Oct 3, 2025
@github-actions github-actions bot added the filigran team use to identify PR from the Filigran team label Oct 3, 2025
@JeremyCloarec JeremyCloarec force-pushed the oob/inputSizeHardLimit branch from 3e3f827 to 3fca289 Compare October 3, 2025 12:55
@JeremyCloarec JeremyCloarec marked this pull request as ready for review October 3, 2025 15:10
@codecov
Copy link

codecov bot commented Oct 3, 2025

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 66.87%. Comparing base (a2cdb90) to head (3c76cf8).
⚠️ Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
...-platform/opencti-graphql/src/database/rabbitmq.js 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12632      +/-   ##
==========================================
+ Coverage   66.53%   66.87%   +0.34%     
==========================================
  Files         752      752              
  Lines       79741    79847     +106     
  Branches     8557     9021     +464     
==========================================
+ Hits        53056    53400     +344     
+ Misses      26685    26447     -238     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@xfournet xfournet added this to the Release 6.9.0 milestone Oct 6, 2025
@SouadHadjiat SouadHadjiat self-requested a review October 7, 2025 08:23
@JeremyCloarec JeremyCloarec force-pushed the oob/inputSizeHardLimit branch from d4141d8 to ba79618 Compare October 8, 2025 09:28
@JeremyCloarec JeremyCloarec force-pushed the oob/inputSizeHardLimit branch from cdeaac3 to e03a5ff Compare October 13, 2025 07:40
@JeremyCloarec JeremyCloarec force-pushed the oob/inputSizeHardLimit branch from e03a5ff to ef5b4f9 Compare October 15, 2025 08:54
log_level: 'info'
telemetry_enabled: false
telemetry_enabled: false
objects_max_refs: 0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

did you manage to find a good default value to be used in Filigran SaaS ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not yet, haven't tested enough to have a clear guideline on the value to set

@JeremyCloarec JeremyCloarec changed the title [backend/worker] handle too large items [backend/worker] handle too large items (#12816) Oct 15, 2025
@JeremyCloarec JeremyCloarec merged commit 5b80965 into master Oct 16, 2025
11 checks passed
@JeremyCloarec JeremyCloarec deleted the oob/inputSizeHardLimit branch October 16, 2025 12:15
@SamuelHassine SamuelHassine removed this from the Release 6.9.0 milestone Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

filigran team use to identify PR from the Filigran team multi-repository For contribution that requires PR in several repository

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a way to send objects from bundles with too many refs to a dead letter queue

5 participants