Skip to content

Decrease ad volume by 75% #239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jayian1890 merged 2 commits into from
Apr 11, 2026
Merged

Decrease ad volume by 75% #239

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
03cd6af
Decrease ad volume by 75%
Jayian1890 Apr 9, 2026
da89903
Refactor ad volume handling to restore original volume after playback…
Jayian1890 Apr 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions opennow-stable/src/renderer/src/components/QueueAdPreview.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,6 +172,21 @@ export const QueueAdPreview = forwardRef<QueueAdPreviewHandle, QueueAdPreviewPro
return;
}

const originalVolume = video.volume;
const restoreOriginalVolume = (): void => {
try {
video.volume = originalVolume;
} catch {
// ignore
}
};

try {
video.volume = Math.max(0, Math.min(1, originalVolume * 0.3125));
} catch {
// Ignore if setting volume is not permitted
}

const handlePlaying = (): void => {
setPlayback("playing");
onPlaybackEventRef.current?.("playing");
Expand Down Expand Up @@ -200,6 +215,8 @@ export const QueueAdPreview = forwardRef<QueueAdPreviewHandle, QueueAdPreviewPro
finishFiredRef.current = true;
onPlaybackEventRef.current?.("ended");
}

restoreOriginalVolume();
};

const handleWaiting = (): void => {
Expand All @@ -217,6 +234,7 @@ export const QueueAdPreview = forwardRef<QueueAdPreviewHandle, QueueAdPreviewPro
const handleError = (): void => {
setPlayback("error");
onPlaybackEventRef.current?.("error");
restoreOriginalVolume();
};

video.addEventListener("loadstart", handleLoadStart);
Expand All @@ -239,6 +257,7 @@ export const QueueAdPreview = forwardRef<QueueAdPreviewHandle, QueueAdPreviewPro
video.removeEventListener("waiting", handleWaiting);
video.removeEventListener("stalled", handleStalled);
video.removeEventListener("error", handleError);
restoreOriginalVolume();
};
}, [mediaUrl]); // intentionally excludes onPlaybackEvent — stored in ref above

Expand Down
Loading