Edge UI: Use browser Language as Default #3415
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
da-Kai
changed the title
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (37.04%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## develop #3415 +/- ##
=============================================
- Coverage 59.60% 59.60% -0.00%
Complexity 112 112
=============================================
Files 2922 2923 +1
Lines 126328 126334 +6
Branches 9412 9401 -11
=============================================
- Hits 75285 75284 -1
- Misses 48185 48197 +12
+ Partials 2858 2853 -5 🚀 New features to boost your workflow:
|
…-browser-language # Conflicts: # ui/src/assets/i18n/de.json # ui/src/assets/i18n/en.json
lukasrgr
requested changes
Dec 1, 2025
Contributor
lukasrgr
left a comment
lukasrgr
left a comment
There was a problem hiding this comment.
Thx for this incremental improvement
| edgeShortName: "OpenEMS", | ||
| edgeLongName: "Open Energy Management System", | ||
| defaultLanguage: "de", | ||
| defaultLanguage: "en", |
Contributor
There was a problem hiding this comment.
das solltest du wahrscheinlich nicht ändern
Contributor
Author
There was a problem hiding this comment.
en macht aber mehr sinn als de
| ], | ||
| "fileReplacements": [ | ||
| { | ||
| "replace": "src/environments/dummy.ts", |
Contributor
There was a problem hiding this comment.
For consistency we should name this file karma.ts dont you think?
Contributor
Author
There was a problem hiding this comment.
dummy.ts ist ja die Datei, die ich ersetzen will.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AuthenticateResponseprovides no language.detoendein Karma tests.Address language issue in #3411