Skip to content

Modularize source files#229

Closed
montlebalm wants to merge 61 commits into218-consistent-stylingfrom
204-modularize-source-files
Closed

Modularize source files#229
montlebalm wants to merge 61 commits into218-consistent-stylingfrom
204-modularize-source-files

Conversation

@montlebalm
Copy link
Member

This PR replaces the current, "big scoped container" approach with one that uses explicit dependencies via browserify. Now, each file pulls in its dependencies using require and browserify combines them at build time.

Changes:

  • Replaced vendored dependencies with npm versions (e.g., eventemitter, easyxdm, and jquery)
  • Broke up files into several smaller parts (e.g., classes, constants)
  • Fixed tests that relied on replacing F2.log with a spy on console.log

@brianbaker brianbaker closed this Oct 27, 2020
@montlebalm
Copy link
Member Author

Let's not be too hasty. There's still time to merge this PR.

@brianbaker brianbaker mentioned this pull request Oct 29, 2020
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants