[BugFix] Nacelle position set inconsistently by glue code and AeroDyn driver#1009
Merged
andrew-platt merged 7 commits intoOpenFAST:devfrom Mar 1, 2022
Merged
Conversation
This was referenced Feb 18, 2022
Collaborator
|
Thanks for fixing this! I noticed that only 4 of the AeroDyn driver test input files were changed. Are the other cases not affected? |
Contributor
Author
Yes, I changed only the affected tests. Tests that use the |
andrew-platt
reviewed
Mar 1, 2022
Collaborator
andrew-platt
left a comment
andrew-platt
left a comment
There was a problem hiding this comment.
Looks good to me! Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Bug description
Pull request #982 changed the way the AeroDyn nacelle point mesh position was set (from
position = InitInp%HubPositiontoposition = InitInp%NacellePosition). The nacelle point mesh position is now defined by the tower top (i.e., yaw bearing) location when AeroDyn is driven by OpenFAST. The AeroDyn driver does not output the nacelle position, so it is set to(0,0,0)when using the driver. This can be fixed by outputting the nacelle position from the AeroDyn driver. However, the driver defines the nacelle position as(0,0,HubHt+overhang*sin(shftTilt)), which is not equivalent to the definition that is passed from the glue code. This causes an inconsistent definition of the nacelle mesh position when using the glue code vs driver.Related issue, if one exists
This pull request will close issue #1005.
Impacted areas of the software
AeroDyn driver
Test results
All tests have been updated and pass. A corresponding pull request (#51) has been added to the r-test repository.
Documentation
Relevant documentation has been updated.