Skip to content

BugFix: Fix typo in DLLEXPORT attributes for IfW C interface#1144

Merged
rafmudaf merged 1 commit intoOpenFAST:devfrom
pablo-benito:IfW_C_Binding_fix
Jun 1, 2022
Merged

BugFix: Fix typo in DLLEXPORT attributes for IfW C interface#1144
rafmudaf merged 1 commit intoOpenFAST:devfrom
pablo-benito:IfW_C_Binding_fix

Conversation

@pablo-benito
Copy link
Contributor

Feature or improvement description

Compilation fix under Windows + GCC (IfW_C_Binding.f90)
The DLLEXPORT attribute in the compiler directives must match the subroutine names, otherwise the compiler throws an error

Related issue, if one exists

Pull request #720

Impacted areas of the software

Additional supporting information

Test results, if applicable

The names of the DLLEXPORT attribute must match the subroutine name
Copy link
Collaborator

@andrew-platt andrew-platt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this! I'm not sure how this was missed originally.

@andrew-platt andrew-platt requested a review from rafmudaf June 1, 2022 13:35
@rafmudaf rafmudaf changed the title Compilation fix under Windows + GCC (IfW_C_Binding.f90) BugFix: Fix typo in DLLEXPORT attributes for IfW C interface Jun 1, 2022
@rafmudaf rafmudaf merged commit fd55498 into OpenFAST:dev Jun 1, 2022
@rafmudaf
Copy link
Collaborator

rafmudaf commented Jun 1, 2022

Thank you @pablo-benito!

@rafmudaf rafmudaf added this to the v3.2.0 milestone Jun 1, 2022
@pablo-benito pablo-benito deleted the IfW_C_Binding_fix branch June 1, 2022 19:14
@rafmudaf rafmudaf mentioned this pull request Jul 8, 2022
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments