Conversation
- Added bending moment calculations in Line::GetStateDeriv. - Required functions for transmitting moments to attached Rods already were in place. - Adjusted Rod initialization to support zero-length rods. - Not yet tested!
- See Implemenation Plan Word doc for any theory questions - Turned on the normal vector output in getDepthFromBathymetry in MoorDyn_Misc - Added all relevant parameter variables to the Registry MoorDyn.f90 - Defining parameters in the beginning of MoorDyn.f90 - - Can add/delete friction parameters as needed later - Read in the friction parameters through the OptString/OptValue process similar to the other Options parameters - Change each call to getDepthFromBathymetry to include the normal vector option - - This is done in the Rod source file as well MoorDyn_Line.f90 - Define all new friction-related parameters used for the calculations - New implementation that includes the seabed slope and the difference between transverse and axial friction into the calculation of forces on each line node - - If the line node is below the water depth, then it has a 3D normal force and a 3D friction force, with axial and transverse components - - These forces then sum into the "bottom contact" variable "B" to be included in the summation of forces
- I don't know what this file means exactly so I'm pushing it here just in case its needed for anything else later, but can also be uncommitted later
- Needed an option to set FkA and FkT to zero when the velocity was zero, rather than divide by a zero velocity magnitude - Indented all the friction force calculations to be calculated when a line node is below the seabed, rather than calculating a friction force for all line nodes - Added indices to the tempVector calculation in getDepthFromBathymetry - Changed the dc_dx and dc_dy calculations to be a double negative (positive), since the c values of the bathymetry grid are positive depths
- Added filtering in MD driver to smooth position inputs and compute smooth positions, velocities, and accelerations to drive MoorDyn with. (This does not necessarily make much difference.) - Fixed a but with line outputs where a line break would occur in a row of time series data after the node positions.
Resolved some conflicts combining new MDv2-farm meshes with new ElastoDyn y3 mesh, and a few others related to MD linearization. This now compiles without error. Not run yet. Conflicts were: - .gitignore - modules/hydrodyn/src/HydroDyn.f90 - modules/hydrodyn/src/HydroDyn.txt - modules/hydrodyn/src/HydroDyn_Input.f90 -modules/hydrodyn/src/HydroDyn_Types.f90 - modules/openfast-library/src/FAST_Lin.f90 - modules/openfast-library/src/FAST_Registry.txt - modules/openfast-library/src/FAST_Solver.f90 - modules/openfast-library/src/FAST_Subs.f90 - modules/openfast-library/src/FAST_Types.f90
- Updates to bring MoorDyn input file format to hopefully its final form. - BODY section now has separate inputs for ID number and attachment type. - Body inputs now support single or 3D (separated by "|") values for CG, I, CdA, and Ca. - LINES section has had columns rearranged to the following order: ID LineType AttachA AttachB UnstrLen NumSegs Outputs - Changed input parsing of depth/bathymetry input option to avoid potential bug of it seeing an "E" for exponent and then treating the number as an input filename. Handling is now more general. - Updates have not been tested in all conditions (Bodies, bathymetry...)
…nd velocity at 3/4 or AC
MoorDyn: - Increased interp order of MoorDyn Driver to 1. Using 0 caused large tension discrepancies. - MoorDyn Driver active tensioning inputs are currently disabled. - Added support for alternative MoorDyn depth keywords: wtrdpth, depth, and waterdepth - Added acceleration output channels for rods and points. - Fixed up wave and current kinematics abilities. FAST.Farm: Commented out timers and print statements in OpenMP option to avoid some compile problems.
32bf56f (Merge remote-tracking branch 'andy/MDv2+SrvDLin' into MDv2)
- Added/adjusted some error handling for Rods - Added some error handling for WaterKin input files, where previously file reading errors were not producing messages. HydroDyn/Morison: Added a catch to avoid divide be zeros when calculating centroid of tapered member segments (if somehow they have zero radius).
This was set to v142, which is not compatible with Visual Studio C++ 2015 that some people are still using.
Collaborator
Author
|
I've added the proposed change log to the PR comment, so please let me know if there's anything missing. |
ebranlard
approved these changes
Oct 27, 2022
jjonkman
reviewed
Oct 28, 2022
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
A few minor documentation improvements and this should be ready to merge!
Collaborator
Author
|
I had incorrectly included these pull requests in the release notes, and they have now been removed: |
Collaborator
|
I think we might be missing notes on #1248 |
Collaborator
Author
It's at the beginning in the "General" section. |
jjonkman
approved these changes
Oct 28, 2022
Collaborator
jjonkman
left a comment
jjonkman
left a comment
There was a problem hiding this comment.
Thanks for addressing my comments!
andrew-platt
approved these changes
Oct 28, 2022
Contributor
|
Windows executables here: https://github.com/bjonkman/openfast/releases/tag/v3.3.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
Pull request to merge
mainintodevand create a tagged release forv3.3.0.See the milestone and project pages for additional information
Test results, if applicable
See GitHub Actions
Release Checklist
Proposed Change Log
General
#1183 Fix bugs and issues in the online documentation
#1248 OpenFAST Registry: allow pointers
AeroDyn
#1000 Updates of Unsteady Aero (UAMod=4) and DBEMT (DBEMT_Mod=3) for linearization
#1037 Bug fix: BEMT was disabled for negative inflow
#1042 AD: merge more of
TwrInflandTwrInflArrayroutines#1061 Fix AeroDyn WriteOutput linearization (and cleanup some code)
#1078 Enable cavitation calculation and outputs using FVW
#1188 AD15 driver: add visualization option for line meshes in addition to surfaces
#1239 AeroAcoustics: fix BL-thickness for heavily-tripped airfoil
HydroDyn
#999 Fix HD added mass on member end (Close #992)
#1230 HD: increase max length of line read from kinematics files
MoorDyn
#1086 MoorDyn v2 + shared moorings + wave propagation in FAST.Farm
MAP++
#1186 MAP: allow keyword
fixedandfixNWTC Library
#1254 NWTC Library and WriteOutput updates
Build System
#1198 Option to disable variable tracking with GNU compiler
#1228 r-test: Remove -m64 in CMAKE_Fortran_FLAG from r-test
Testing System
#1203 Add parallel branches to GitHub Actions
#1217 Consolidate regression test baseline set
#1222 Improvements to regression test python scripts
#1244 Reg-test scripts modification to help avoid race condition and cleanup of caselist
#1264 GitHub Workflow: adding build-all-debug-single to check type errors
C++ API
#1176 Simulink: add documentation of inputs to FAST_Library.h
#1211 Use dt_out when storing OpenFAST outputs in Python interface
#1227 Seg Fault due to hub model and external inflow
Linearization
#1199 Small improvements for -VTKLin visualization outputs