Fix for Visual Studio builds with ADI#1317
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Nov 9, 2022
Merged
Conversation
- removed non-standard tab formatting from AD - added ADI to RunRegistry.bat for VS builds - removed some unused variables - removed extrap/interp routines from AFI, AA, and ADI types (cmake); now should be consistent in cmake and VS_build
andrew-platt
approved these changes
Nov 8, 2022
Contributor
|
I suspected the parallelization of FWrap Init to be buggy. I've removed it and the tests seem to pass now... |
Contributor
Author
|
Thanks, @ebranlard! |
Contributor
Author
|
FWIW: when I pulled up the GitHub Action artifacts of the failing FAST.Farm case (before Emmanuel reverted that change in dev), the plots are unreadable:
I haven't spent any time trying to figure out what's going wrong there, but thought I'd draw it to someone's attention. The other PRs that I submitted about the same time also failed on the same case as this one, but they didn't produce any .html file. So, something strange is going on with that. |
Contributor
|
Yes, I've noticed this as well, I'm not quite sure what's going on. I ended up comparing the files in pyDatView instead. |
Collaborator
|
I'm able to reproduce this locally as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is ready to be merged.
Feature or improvement description
This PR updates the build process so that ADI's registry runs in the VS solution files. It also
Impacted areas of the software
Visual Studio builds with code that contains the ADI module.
Test results, if applicable
This does not change any results