Cleanup OpenFAST VTK output for HydroDyn#1319
Merged
andrew-platt merged 1 commit intoOpenFAST:devfrom Nov 9, 2022
Merged
Conversation
andrew-platt
approved these changes
Nov 9, 2022
|
|
||
| ! Blades | ||
| IF ( p_FAST%CompAero == Module_AD ) THEN ! These meshes may have airfoil data associated with nodes... | ||
| IF ( p_FAST%CompAero == Module_AD .and. ALLOCATED(AD%Input) ) THEN ! These meshes may have airfoil data associated with nodes... |
Collaborator
There was a problem hiding this comment.
Could this potentially fail with AD14 or AeroDisk in use? If I remember correctly, AD%Input will be allocated even if AD15 isn't used, but things inside it wouldn't be.
Collaborator
There was a problem hiding this comment.
Never mind. This is not an issue (reread logic above).
Contributor
Author
There was a problem hiding this comment.
The biggest concern is that if the code is aborting due to error and is trying to output the DebugError versions of the VTK files, we need to make sure things are allocated before using them. We should probably also check that AD%Input(1)%rotors and AD%y%rotors are allocated. I'll add that to another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
I have cleaned up the HydroDyn meshes that are written as VTK files when all meshes are output. This update makes sure all 3 HD input meshes can be output, and their sibling meshes are also output. The names of these VTK files have been updated to match names in the code.
Related issue, if one exists
None.
Impacted areas of the software
VTK output of HD meshes
Test results, if applicable
This does not change any test results.