add version info to c-binding libraries#1327
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Nov 22, 2022
Merged
Conversation
ebranlard
approved these changes
Nov 16, 2022
ebranlard
approved these changes
Nov 16, 2022
Contributor
ebranlard
left a comment
There was a problem hiding this comment.
This looks good to me, thanks for doing that.
3f57504 to
6f632a7
Compare
OpenMP causes dynamic linking of the libiomp5md.dll library. This causes headaches for trying to load these libraries in python >3.7
6f632a7 to
259c10f
Compare
Collaborator
Author
|
I made a few more updates to the VS projects (noted above). They had a few issues such as missing files. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ready for merging
Feature or improvement description
When c-bindings interfaces are compiled and used in other codes, there was no information output as to which version or git hash was used. This was leading to confusion during debugging of the the OWENS code with the MoorDyn and HydroDyn c-bindings libraries compiled as DLLs.
Other changes:
OpenMPfrom VS projects forc_bindingsThis was causing issues when trying to load the DLL from python 3.8 or higher due to a dependency on the
libiomp5md.dlllibrary (from OpenMP). This is an issue for 3.8 and later as the path to every DLL outside the system directories must be explicitly added. For the VS project for ADI, another option was added forRelease_OpenMP.Related issue, if one exists
none
Impacted areas of the software
aerodyn_inflow_c_bindinglibraryhydrodyn_c_bindinglibraryifw_c_bindinglibraryTest results, if applicable
The regression tests for these library interfaces now output the version info.
Example output from
py_ad_5MW_OC4Semi_WSt_WavesWNcase