AeroDyn/UnsteadyAero_Driver: Fix for bug #1346#1356
Merged
ebranlard merged 2 commits intoOpenFAST:devfrom Nov 29, 2022
Merged
Conversation
ebranlard
approved these changes
Nov 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes a bug in AeroDyn/UnsteadyAero_Driver:
bug #1346: If SimMod==1 (reduced frequency model) is used, non-allocated variables are handed over to subroutines with intent(in), which causes a runtime error.
Feature or improvement description
Fix for bug #1346, added some if clauses and making some arrays 'optional'.
Related issue, if one exists
#1346
Impacted areas of the software
AeroDyn -> UnsteadyAero_Driver.f90
Additional supporting information
UnsteadyAero_Driver is only used for stand-alone run of a single airfoil unsteady aerodynamics tests.
This PR was originally #1347, but there was a mixup on our end with the merge. I have recreated this with the merge commit to main and the original text from #1347. Many thanks to @RiekJ for your contribution and patience with our mixup