Skip to content

Force the numerical hydrostatic load calculation to use double precision#1612

Merged
andrew-platt merged 4 commits intoOpenFAST:devfrom
luwang00:dev2
Jun 8, 2023
Merged

Force the numerical hydrostatic load calculation to use double precision#1612
andrew-platt merged 4 commits intoOpenFAST:devfrom
luwang00:dev2

Conversation

@luwang00
Copy link
Contributor

@luwang00 luwang00 commented Jun 7, 2023

Feature or improvement description
Use double precision when computing the hydrostatic loads with MHstLMod=2 even if DOUBLE_PRECISION:BOOL=OFF. This change avoids numerical problems encountered with single-precision build when using MHstLMod=2.

Impacted areas of the software
The changes only impact the Morison module of HydroDyn (Morison_CalcOutput).

Test results, if applicable

  • This pull request does not impact the test results of existing r-tests, which do not cover MHstLMod=2.
  • Offline testing suggests the hydrostatic load is now correctly calculated with MHstLMod=2 when DOUBLE_PRECISION:BOOL=OFF.

@andrew-platt andrew-platt self-requested a review June 7, 2023 20:46
@andrew-platt andrew-platt self-assigned this Jun 7, 2023
@andrew-platt andrew-platt added this to the v4.0.0 milestone Jun 7, 2023
@andrew-platt andrew-platt marked this pull request as ready for review June 7, 2023 21:24
@andrew-platt andrew-platt merged commit ca79d10 into OpenFAST:dev Jun 8, 2023
@luwang00 luwang00 deleted the dev2 branch October 9, 2023 19:52
@andrew-platt andrew-platt mentioned this pull request Dec 24, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments