[BugFix] OpenFAST Registry on Windows#1618
Merged
deslaughter merged 3 commits intoOpenFAST:dev-unstable-pointersfrom Jun 9, 2023
Merged
[BugFix] OpenFAST Registry on Windows#1618deslaughter merged 3 commits intoOpenFAST:dev-unstable-pointersfrom
deslaughter merged 3 commits intoOpenFAST:dev-unstable-pointersfrom
Conversation
This commit removes the dependency on std::filesystem which is not well supported by all compilers. This will now compiler on VS2015. This also fixes some bugs with generating templates and registry files when beginning a new module.
Visual Studio can't handle mixing C and Fortran source in the same library. This commit splits the C and Fortran into two libraries.
deslaughter
requested review from
andrew-platt and
ebranlard
and removed request for
ebranlard
ebranlard
approved these changes
Jun 9, 2023
Collaborator
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to be merged.
Feature or improvement description
This PR resolves several issues with building the new OpenFAST Registry (C++) on Windows. The dependency on
std::filesystemhas been removed so it is compatible with older compilers (tested with VS2015). It also fixes a Visual Studio compiler issue with the strings intemplates.hppbeing too long.Secondly it fixes an issue with the MAP library which occurs when combining C and Fortran sources in a single library and then generating a Visual Studio Solution via CMake. This is accomplished by splitting MAP into C and Fortran libraries. This requires that both libraries are added to the Simulink project.
Impacted areas of the software