Initial AeroMap changes for ElastoDyn and BeamDyn#1631
Merged
andrew-platt merged 7 commits intoOpenFAST:devfrom Jun 20, 2023
Merged
Initial AeroMap changes for ElastoDyn and BeamDyn#1631andrew-platt merged 7 commits intoOpenFAST:devfrom
andrew-platt merged 7 commits intoOpenFAST:devfrom
Conversation
ED bug fix from prev commit 903cf07
- If user requests too many nodal outputs, the max number of outputs will be generated instead of none (as done previously) - call generic LAPACK_GEMM routines instead of writing LAPACK_DGEMM - return after error on Init_MiscVars to prevent issues when writing summary file BD: Explicitly initialize new InitInp in driver
Looks like it got commited accidentally on a rebase command....
andrew-platt
approved these changes
Jun 16, 2023
ebranlard
approved these changes
Jun 20, 2023
Contributor
ebranlard
left a comment
ebranlard
left a comment
There was a problem hiding this comment.
Thank you for sending us these changes.
Contributor
Author
These are the easy ones. :) I'll try to get the AeroDyn and other modules to you "soon" too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feature or improvement description
This PR updates ElastoDyn and BeamDyn with changes needed for AeroMap generation (which will be added in a later pull request, after AeroDyn and InflowWind are also modified). In AeroMaps, linearization is done on only one blade, with a subset of states. Thus, the linearization code in these modules must change.
The flag that activates the new code is set to false, so the code should behave as it did before.
I also updated some comments in FVW and modified some error handling in the ED and BD nodal outputs (it will now still output some of the requested outputs if the number requested exceeds size limits)
Related issue, if one exists
None
Impacted areas of the software
ElastoDyn and BeamDyn, particularly with linearization.
Additional supporting information
Test results, if applicable
This should not change test results.