InflowWind pointers in AeroDyn, OpenFOAM, and Lidar#1639
InflowWind pointers in AeroDyn, OpenFOAM, and Lidar#1639deslaughter merged 5 commits intoOpenFAST:dev-unstable-pointersfrom
Conversation
|
@Russell9798 , could you take a look at the changes to Lidar? |
| ! Hub | ||
| if (u%rotors(iWT)%HubMotion%Committed) then | ||
| call IfW_FlowField_GetVelAcc(p%FlowField, StartNode, t, & | ||
| real(u%rotors(iWT)%HubMotion%TranslationDisp + u%rotors(iWT)%HubMotion%Position, ReKi), & |
There was a problem hiding this comment.
Can we avoid the real conversion here and below? Maybe we need multiple interfaces for IfW_FlowField_GetVelAcc in the future.
There was a problem hiding this comment.
I like the idea of providing an interface for IfW_FlowField_GetVelAcc, it could solve some issues that came up during the integration which made it seem hard to use. I'll play around with it a little and do another commit.
There was a problem hiding this comment.
I took a look at providing multiple interfaces to IfW_GetVelAcc, but it requires declaring whether Position, Velocity, and Accel are always R4Ki or R8Ki. This would require many changes throughout the code. I'll keep thinking about a better solution as I continue to integrate the Flow Field.
3 participants
This pull request is ready to merge.
A test case needs to be added to demonstrate that Lidar still works.
Feature or improvement description
This PR integrates the InflowWind FlowField pointer into OpenFOAM and InflowWind Lidar. It also modifies the AeroDyn to remove the need to collect all node positions for the wind calculation and then unpack the data into the inputs. The
IfW_GetVelAccroutine has been modified to accept a flag which allows the bounding box to be exceeded. This feature is enabled for wind velocity calls from OLAF and Lidar.Impacted areas of the software
Test results, if applicable
Regression test results are unchanged. OpenFOAM changes have not been tested.