Bug Fix with MSL2SWL#1804
Merged
andrew-platt merged 1 commit intoOpenFAST:dev-unstable-pointersfrom Oct 23, 2023
Merged
Conversation
SeaState overwrites WtrDpth with WtrDpth+MSL2SWL, affecting other modules downstream.
andrew-platt
approved these changes
Oct 23, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request fixes the issue identified and does not affect existing test results. However, it would be beneficial to check whether there are other bugs associated with
MSL2SWL!=0.Feature or improvement description
This is a bug fix to address the following issues:
MSL2SWL!=0.Z_Depthcausing an error whenMSL2SWL<0.MSL2SWLincluded (measured from SWL instead of MSL) being passed to the other modules (HydroDyn, SubDyn, MAP++, and MoorDyn).Impacted areas of the software
SeaState, HydroDyn, glue code with changes to the water depth input to SubDyn, MAP++, and MoorDyn.
Additional supporting information
WtrDpthwithWtrDpth+MSL2SWLin SeaStateInitOut, affecting other modules downstream using it as an input.WtrDpthin SeaStateInitOutback to the original water depth from the user input files without the contribution fromMSL2SWL. A new variable calledEffWtrDpthwith the contribution fromMSL2SWLis added to SeaStateInitOutto avoid confusion.WtrDpthof the various submodules ofSeaStateandHydroDynis actually the effective water depth, i.e.,WtrDpth+MSL2SWL. This gives the correct behavior, but it might be beneficial to change the variable name toEffWtrDpthfor clarity, like in the newSeaSt_WaveFieldmodule.Z_Griddid not account for nonzeroMSL2SWL, causing an error. This is now fixed.Test results, if applicable
Does not affect existing test results. Only impacts the results when
MSL2SWL!=0.