Unsteady Aero Driver: adding 3 degrees of freedom for the motion of a genralized airfoil section#1910
Merged
andrew-platt merged 36 commits intoOpenFAST:devfrom Mar 11, 2024
Merged
Conversation
- vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type - vs project needed LinDyn added to it - moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn.
This would have caused issues when merging with the dev-unstable branch of OpenFAST
- update extension of UA output files - explicitly initialize `d_34_to_ac`
* UA driver: vs build - vs project didn't like a `UA_OUTS` as both a preprocessor directive and value inside a type - vs project needed LinDyn added to it - moved override of UA_OUTS to UA driver and added initialization in BEMT & FVW so people could override the value before compiling if they wanted to debug UA inside of AeroDyn. * LinDyn: states should be reals, not logicals This would have caused issues when merging with the dev-unstable branch of OpenFAST * fix typo in RoutineName parameter * UA: minor updates - update extension of UA output files - explicitly initialize `d_34_to_ac`
eaef5b8 to
39ea6c8
Compare
our regression tests found this issue
Collaborator
|
Merge only after bugfix is merged in: |
UA driver bug fix: sim mod 2
Collaborator
|
I see the |
Contributor
Yes. That is only used in the Unsteady Aero driver. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request is soon ready to be merged
Feature or improvement description
Adding 3 degrees of freedom fro the motion of a genralized airfoil section
Impacted areas of the software
Unsteady Aerodynamics
Additional supporting information
A paper will be released at the torque 2024 conference. A link is provided in the documentation.
Test results, if applicable
Input file is backward compatible
Example input file:
UA2.txt