SubDyn summary file: fixes#1911
Merged
andrew-platt merged 2 commits intoOpenFAST:devfrom Dec 4, 2023
RBergua:dev
Merged
Conversation
andrew-platt
requested changes
Dec 3, 2023
Collaborator
andrew-platt
left a comment
There was a problem hiding this comment.
Could you change out the tab characters for spaces? Otherwise I approve
Collaborator
|
For @andrew-platt:
|
andrew-platt
approved these changes
Dec 3, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I believe this pull request can be merged.
Feature or improvement description
SubDyn can output in the summary file (
SumPrint = 1) the cosine matrices (OutCOSM = True).In the summary file, the direction cosine for a spring element is not properly written. The summary file looks as:

As can be observed, the summary file shows only zeros for the spring element. This is because the
subroutine OutSummarytries to get the direction cosine based on the joint 1 and joint 2 of the member (and joint 1 and joint 2 are coincident for springs). In this PR, thesubroutine OutSummaryhas been modified to properly account for the spring element (and arbitrary beams in the future).However, I believe that if the user defines a given direction cosine for a circular beam, the
subroutine GetDirCoswill also compute the direction cosine based on joint 1 and joint 2, effectively overwriting whatever the user provided as input.Impacted areas of the software
SubDyn summary file.
Test results, if applicable

Proper summary file: