Option to turn off unit_tests from cmake#1950
Merged
deslaughter merged 1 commit intoOpenFAST:rc-3.5.2from Dec 21, 2023
Merged
Conversation
Collaborator
Author
|
andrew-platt
requested review from
deslaughter and
jjonkman
and removed request for
jjonkman
deslaughter
approved these changes
Dec 21, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is ready to merge.
Feature or improvement description
Previously anytime the
BUILD_TESTINGoption in CMake was turned on, unit tests would also be run. However, Kestrel cannot currently run the unit testing, so an option to turn that off separately is needed.A new CMake variable
BUILD_UNIT_TESTINGis now turned on ifBUILD_TESTINGis on. This option can be separately specified for scenarios where pfunit used in testing is not available.Related issue, if one exists
#1948
Impacted areas of the software
Unit testing.
Additional supporting information
We are currently using
pfunitversion 3.2.10, which is 6+ years old (current version is 4.8). We don't have resources at present to deploy the newerpfunitor fix the issues on Kestrel, so a workaround is needed for these rare cases.Test results, if applicable